Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is port of Blizzard/node-rdkafka#857 by @Twixes, that registers the module with
NAN_MODULE_WORKER_ENABLED
, for compatibility with worker_threads.Testing
test/index.spec.js
confirms that the module is now available in a worker threadCompatibility
nan transparently falls back to the old API for versions older than 10. I tested it with
node-v8.0.0-darwin-x64
(build and test run fine).Do we need cleanup?
Looking at PRs on other libraries, I found that this one adds a call to
node::AddEnvironmentCleanupHook
to avoid leaking resources on worker exit. I'll need to check the codebase to see whether it's needed here.